This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add MGLCompassButton and MGLOrnamentVisibility #15055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9562 by adding
MGLCompassButton.visibility
(and, well,MGLCompassButton
).Changes
MGLMapView.compassView
is now anMGLCompassButton
, a subclass ofUIImageView
(its former type).MGLMapView
and intoMGLCompassButton
.MGLOrnamentVisibility
constants, with options foradaptive
,visible
, andhidden
. These can later be adopted by other ornaments, should we so choose.To-do
RenameMGLCompassButton
toMGLCompassView
?Consider whether or not to allow arbitrary compasses that aren’t necessarily map subviews.